unicef / iogt-pwa

A UNICEF-led digital solution transforming lives and providing opportunity, by making knowledge universally accessible.
https://www.internetofgoodthings.org/
Other
3 stars 2 forks source link

Hotfix for importing Google font in Footer CSS stylesheet #11

Closed nathanbaleeta closed 3 years ago

nathanbaleeta commented 3 years ago

Describe the bug Importing the google font at the top of the CSS stylesheet of the footer causes a CssSyntaxError and thus build process fails.

To Reproduce Steps to reproduce the behavior:

  1. git clone https://github.com/unicef/iogt-pwa.git
  2. cd iogt-pwa/frontend
  3. yarn install
  4. yarn run build

Expected behavior Build process should be successful when you run yarn run build

Screenshots Screenshot from 2020-10-01 14-30-50

Desktop (please complete the following information):

Additional context To enable successful build, had to comment out the css google font on the first line: https://github.com/unicef/iogt-pwa/blob/develop/frontend/src/components/footer/style.css

Steps to fix it

harshiniwho commented 3 years ago

/take

harshiniwho commented 3 years ago

/take

Shall try to fix this! I guess it is the external reference not being parsed correctly for some reason.

harshiniwho commented 3 years ago

https://github.com/unicef/iogt-pwa/pull/12

I seem to be unable to request review but linking the PR here

nathanbaleeta commented 3 years ago

12

I seem to be unable to request review but linking the PR here

Creating a new branch off develop should be enough to help you raise a pull request once you have made any changes.