Closed nathanbaleeta closed 3 years ago
/take
/take
Shall try to fix this! I guess it is the external reference not being parsed correctly for some reason.
https://github.com/unicef/iogt-pwa/pull/12
I seem to be unable to request review but linking the PR here
12
I seem to be unable to request review but linking the PR here
Creating a new branch off develop
should be enough to help you raise a pull request once you have made any changes.
Describe the bug Importing the google font at the top of the CSS stylesheet of the footer causes a
CssSyntaxError
and thus build process fails.To Reproduce Steps to reproduce the behavior:
git clone https://github.com/unicef/iogt-pwa.git
cd iogt-pwa/frontend
yarn install
yarn run build
Expected behavior Build process should be successful when you run
yarn run build
Screenshots![Screenshot from 2020-10-01 14-30-50](https://user-images.githubusercontent.com/8824104/94804060-e68e8180-03f2-11eb-9916-d598178b1f17.png)
Desktop (please complete the following information):
Additional context To enable successful build, had to comment out the css google font on the first line: https://github.com/unicef/iogt-pwa/blob/develop/frontend/src/components/footer/style.css
Steps to fix it
develop
calledhotfix-import-google-font-footer
. Hint:git checkout -b <new-branch> <existing-branch>
yarn run build
before pushing changes to github.git push --set-upstream origin hotfix-import-google-font-footer