unicef / kindly

GNU Affero General Public License v3.0
24 stars 17 forks source link

Google sheet api #114

Closed sabinevidal closed 2 years ago

sabinevidal commented 2 years ago

Github Workflow which runs once a day (cron schedule commented out for now) Authenticates to Google Cloud via Workload Identity Federation using the Google auth action. This approach is best for backend communication between APIs, and is safer than the original Google Cloud service keys and is more long-lived than the OAuth token.

Node script then runs which requests the data from the output sheet and then adds it to the training_data file in json format as discussed in #109

Still need to do:

sabinevidal commented 2 years ago

@nathanfletcher @lacabra: Have created a draft PR to check my logic. I'm not sure of the best way to test as auth is required.

edit: have left the cron job commented until I'm sure my logic is sound as don't want to trigger any errors at 4am!

lacabra commented 2 years ago

The description of this PR does not include a mention about modeling/dataset/luisport_combined.js.

Why do you have this script? and what is it used for?

sabinevidal commented 2 years ago

The description of this PR does not include a mention about modeling/dataset/luisport_combined.js.

Why do you have this script? and what is it used for?

This script was just in the draft until #109 was merged into main. Have now updated!

sabinevidal commented 2 years ago

@nathanfletcher @lacabra : have added the commit workflow to make sure the updated training_data.json file is saved. Just need to insert the email and username. What would you suggest for those? Added my email and username for now.

nathanfletcher commented 2 years ago

new secrets added for further testing cc @sabinevidal