search

unicef / kindly

GNU Affero General Public License v3.0
24 stars 17 forks source link

RESOLVING HTTP 403 during TOKEN authorization #33 #56

Closed Simpleshell3 closed 2 years ago

Simpleshell3 commented 2 years ago

HTTP 403 solved after enforcing authorization tokens in file and here.

result

Simpleshell3 commented 2 years ago

@nathanfletcher hello, I have rebased my fork.

nathanfletcher commented 2 years ago

@nathanfletcher hello, I have rebased my fork.

@Simpleshell3 thanks for the rebase. it looks cleaner now. I also appreciate the additions to the docs. I'm going to double back on the comment I made about adding a localhost:port to the allowed origins. I did not mean it literally, sorry for the confusion. However, I also think there's a better way to let new developers working on this to know to include their local running host and port to the list. I'm thinking either on the lines of through documentation or maybe an environment variable. What do you think?

Simpleshell3 commented 2 years ago

@nathanfletcher I think .env file contains the individual user environment variables that override the default systems variables set . Any dev can customize the environment variables as desired by modifying their own .env file.

I think we can create .env.development for dev, and the use .env.template file to document all the values being used in Kindly. Since, we wouldn’t want to commit local variables in .env files, the template files, will make it easier to create .env files by copy/pasting them on the server running build.

lacabra commented 2 years ago

The underlying issue of this PR has been addressed and superseded by #57, which has been merged by now; hence closing this PR as duplicate.