Unit Tests for API - Githubissues

unicef / kindly

GNU Affero General Public License v3.0

24 stars 17 forks source link

Unit Tests for API #61

Closed sabinevidal closed 3 years ago

sabinevidal commented 3 years ago

@Ashara-kosi

sabinevidal commented 3 years ago

@nathanfletcher or @lacabra What's the best way for @Ashara-kosi to access and add commits to this branch I created? Would cloning my fork of the Kindly repo and then checking out this branch be the best?

lacabra commented 3 years ago

@sabinevidal I believe the easiest would be for you to add @Ashara-kosi as a contributor to your forked repo, so that she can push contributions to feature branch api-unit-tests on your repo, which will automatically appear on this PR.

sabinevidal commented 3 years ago

@lacabra Have made requested changes and added more endpoint tests. Notes:

used pytest-dotenv as pytest-env is unmaintained
the /train endpoint seems to be incomplete as NameError: name 'emotion' is not defined is thrown when trying to access. Have added one test for it, but have commented it out.
Added tests for expected errors currently in api.py for each endpoint ie 400 and 403 and one generic 403.

sabinevidal commented 3 years ago

@lacabra Great! Have made some improvements from pylint now! 😁

I encountered the following error due to conflicting dependencies when re-installing the requirements, but pylint still seemed to work despite this:

ERROR: Cannot install -r requirements.txt (line 16) and tensorflow==2.6.0 because these package versions have conflicting dependencies.

The conflict is caused by:
    pylint 2.11.1 depends on typing-extensions>=3.10.0; python_version < "3.10"
    tensorflow 2.6.0 depends on typing-extensions~=3.7.4

Thankfully looks like this particular one, the typing-extensions, will be updated in the next release of Tensorflow. But everything seems to be working otherwise.

sabinevidal commented 3 years ago

@lacabra Yaay! 🥳 Hahaha, thankfully there won't be any 'breaking' ramifications 😅

Will keep an eye out for any changes to endpoints which I can add to the tests if needed in the future 👀

lacabra commented 3 years ago

@sabinevidal I have just added a new issue to build on your work, to automatically run these unit tests on every commit, to make sure that new contributions don't break the functionality. If you are interested to work on #80, it may be a good continuation of your work here and a good learning opportunity.