search

unicef / kindly

GNU Affero General Public License v3.0
24 stars 17 forks source link

Add GitHub Actions to enforce unit tests in CI #80

Closed lacabra closed 2 years ago

lacabra commented 2 years ago

As a result of implementing unit tests in #61, the next steps is to automatically run these on every commit through GitHub Actions to ensure that any new contributions do not break the existing functionality (and that new functionality will include the corresponding unit tests). For an example of a related implementation (using Javascript instead of Python), refer to the CI implementation from the unicef/publicgoods-candidates repository.

sabinevidal commented 2 years ago

@lacabra Will take this on next!

sabinevidal commented 2 years ago

@lacabra Just to confirm my understanding - should there be a test that ensures all new functionality includes a test? "(and that new functionality will include the corresponding unit tests)"

lacabra commented 2 years ago

No, no, that was a generic statement. The scope of work for this PR is limited to automating the running of unit tests through GitHub Actions on every commit, please forget about accounting for any new functionality.

sabinevidal commented 2 years ago

Ok cool! Figured that was a bit too generic and broad for this PR 😅

sabinevidal commented 2 years ago

Hi @lacabra ! Think this issue would be closed by #91 unless there's anything else which needs to be added?

lacabra commented 2 years ago

Yes, indeed, thanks for catching this 🙏