search

unicef / kindly

GNU Affero General Public License v3.0
24 stars 17 forks source link

Github actions for Python code style #90

Closed NayOoLwin5 closed 2 years ago

NayOoLwin5 commented 2 years ago

fixes #64 Added and tested for Pylint. Waiting for your feedback.

nathanfletcher commented 2 years ago

@NayOoLwin5 thanks for your contribution. I'll take a look

sabinevidal commented 2 years ago

@nathanfletcher This CI implementation is focused just on pylint, while mine on #83 is implementing CI on GitHub for the unit tests. But they should ideally be within the same file. I've hit a snag on mine (about to comment), but maybe this action could be moved to a new file eg ci.yml which I will then pull and add my code to instead. (or vice versa). I'm not sure what best practice would be, but is it best to separate GitHub action workflows into different files? In this case main.yml for the docker build check and maybe ci.yml for continuous integration specifically checking pylint (maybe other linter checks?) and unit tests?

NayOoLwin5 commented 2 years ago

Sure @lacabra.. I will add this CI implementation in ci.yml. Just to clear a doubt, there is already build-3_6 job in that workflow. I will need to add Pylint for both Python versions, right? Means there will be two jobs build-3_6 and build in that workflow.

lacabra commented 2 years ago

No, simply adding it to the build stage with 3.8 is enough. Thanks

NayOoLwin5 commented 2 years ago

@lacabra I have updated this CI. The test scores are 10/10 for all the Python files in my fork Actions.

lacabra commented 2 years ago

Looking good, thanks @NayOoLwin5 It's great to have all these checks in place! 💪