unicef / magicbox-maps

Map mobility data in a NodeJS + React front-end application with data served by magicbox-open-api
http://magicbox-maps.azurewebsites.net
BSD 3-Clause "New" or "Revised" License
11 stars 11 forks source link

Add initial feature click handler for schools #68

Closed carloscdias closed 6 years ago

carloscdias commented 6 years ago

Summary

This PR adds a simple handler for click on schools, similar to the one presented here. It can be used as an example to develop new and more complex handlers.

rdebeasi commented 6 years ago

Looks great!

The new name property appears in the sample JSON but not in the full data. @mikefab, would it be possible to add the name field to this data so that this code works with test or "real" data? (Or if there's a way I can do it, just let me know). Thank you!

rdebeasi commented 6 years ago

After speaking with Mike and David yesterday, it sounds like David's work on the aggregation story will probably result in us getting more "real" data. Carlos noted that any properties other than color will be displayed in the popup, so we probably can live without the name property for now.

Anyway, looks great - merging!