rdebeasi
commented
6 years ago I've made the changes we discussed yesterday. The file paths now live in environment variables. See the readme for more details.
This setup has a few benefits:
- File URLs don't appear in source control.
- We can easily swap out for a "real" API in the future.
- You can't accidentally check in the data or URL, because
.env.localis ignored. - There's no need to manually replace the dummy data with real data on the server.
I've set the appropriate environment variables in OpenShift. When building in another environment (e.g., Jenkins on Auzre), don't forget to set the environment variables there.
To keep the old URL from appearing in history, please merge this PR as a "squash" commit and delete the branch afterwards.
This PR adds a config file so that we can easily switch the paths to data files. That makes it easier to switch to from files to an API in the future. The application now loads all school data (rather than a few representative points) from a temporary Azure blob store.
In the future, this should be replaced by long-term file storage, and potentially connected to a simple API.