unicef / magicbox-maps

Map mobility data in a NodeJS + React front-end application with data served by magicbox-open-api
http://magicbox-maps.azurewebsites.net
BSD 3-Clause "New" or "Revised" License
11 stars 11 forks source link

Add mapbox token as an environment variable #83

Closed carloscdias closed 6 years ago

carloscdias commented 6 years ago

Summary

This PR expects a new environment variable called REACT_APP_MAPBOX_TOKEN to exist and stores it as mapboxToken inside the helper file api-config in order to use this value as the token to access mapbox.

rdebeasi commented 6 years ago

Awesome, thank you! You'll also need to add the environment variable to:

If you haven't already, be sure to ask Mike to add his mapbox token to the Azure environment so that it can be used there.

A day or two after this PR is merged, I will deactivate the API key that's currently being used.

carloscdias commented 6 years ago

Thanks for catching that @rdebeasi let me know if everything seems ok now. @mikefab We need to add this variable in Azure

rdebeasi commented 6 years ago

Looks good to me! I will hold off on merging this until the variable is added to Azure.

Thanks!

rdebeasi commented 6 years ago

Hi all! Just a reminder that the application is still using my Mapbox API token. I'm planning to deactivate that API token in June.

Please don't forget to:

Thank you!!

rdebeasi commented 6 years ago

Hi folks! Just a friendly reminder that the old API token will be disabled in a few weeks. Before the end of May, please add your own (free) API token in Azure and merge this PR. If for some reason there's a problem with this PR and it cannot be merged, you could hard-code a different API token as a stopgap solution.

I need to deactivate the existing token at the beginning of June. If a new API token is not supplied by then, the dev environment for magicbox-maps v2 will stop displaying the map until a new API token is added.

I'm happy to answer any questions that you might have. Thank you! :smile:

@mikefab @carloscdias @jflory7