unicef / magicbox

A platform that uses real-time data to inform life-saving humanitarian responses to emergency situations
https://www.unicef.org/innovation/Magicbox
BSD 3-Clause "New" or "Revised" License
86 stars 16 forks source link

Write section on best practices for reviewing a PR in GitHub Workflow doc #38

Closed jwflory closed 6 years ago

jwflory commented 6 years ago

Summary

Finish writing the section Reviewing pull requests in Github Workflow doc

Background

@thoat and I had a conversation today about this section in the docs and what I meant with some of my notes – from the explanation, it would be more or less easy to update the documentation to be complete and make sense.

Details

It's mostly expanding on the existing notes on following best practices when reviewing a pull request and how to be effective with reviewing them.

I assigned this to me because this one is easier and still fresh in mind. I think I'll be able to do this in a week or less. :slightly_smiling_face:

Outcome

Easier to understand best practices for reviewing new pull requests and what steps to follow when someone makes a new pull request