search

unicef / magicbox

A platform that uses real-time data to inform life-saving humanitarian responses to emergency situations
https://www.unicef.org/innovation/Magicbox
BSD 3-Clause "New" or "Revised" License
86 stars 16 forks source link

Add best practices for reviewing pull requests (closes #38) #40

Closed jwflory closed 6 years ago

jwflory commented 6 years ago

This pull request adds a missing section to the documentation that I wasn't able to complete back in May. It covers best practices when reviewing a pull request and what steps to follow when looking at a contribution. This also closes #38.

@mikefab @thoat Would either of you mind taking a look and reviewing?

I tested my changes locally, and a rendered preview is below:

Rendered preview of 'Reviewing pull requests' section in GitHub workflow

jwflory commented 6 years ago

Anyone have a chance to look at this yet?

thoat commented 6 years ago

Adding Vinit as a reviewer since it's good to have an extra pair of eyes, especially since Mike has been busy last week and this week working on a demo for a DRC telco.

jwflory commented 6 years ago

Given the prior approval per the instructions in the contributing guidelines, I am going to merge this in. :clapper:

Thanks for the review, @thoat!