unicef / material-ui-currency-textfield

Currency textfield for React Material UI

https://unicef.github.io/material-ui-currency-textfield/

116 stars 94 forks source link

Warning: componentWillReceiveProps has been renamed... #18

Open miliu99 opened 4 years ago

miliu99 commented 4 years ago

I got this warning in browser:

Warning: componentWillReceiveProps has been renamed, and is not recommended for use. See https://fb.me/react-unsafe-component-lifecycles for details.

Move data fetching code or side effects to componentDidUpdate.
If you're updating state whenever props change, refactor your code to use memoization techniques or move it to static getDerivedStateFromProps. Learn more at: https://fb.me/react-derived-state
Rename componentWillReceiveProps to UNSAFEcomponentWillReceiveProps to suppress this warning in non-strict mode. In React 17.x, only the UNSAFE name will work. To rename all deprecated lifecycles to their new names, you can run npx react-codemod rename-unsafe-lifecycles in your project source folder.

Please update the following components: CurrencyTextField

Any chance to update the component?

SashaDesigN commented 4 years ago

looks like this component is not supported anymore

FlorianBouron commented 4 years ago

looks like this component is not supported anymore

Where did you see this? I was wondering if creating a pull request might help to make this going forward.

AlanC5 commented 3 years ago

I'm looking forward to fix for this warning as well. @FlorianBouron did you get a chance to create a pull request?

sureshsevarthi commented 3 years ago

@FlorianBouron and @AlanC5 Please create a pull request, if you fixed the issue. We will merge.

peacechen commented 3 years ago

Are there any active maintainers who will merge if I submit a PR?

sureshsevarthi commented 3 years ago

Sure. We will accept PR's and merge.

On Tue, Apr 20, 2021 at 5:27 PM Peace @.***> wrote:

Are there any active maintainers who will merge if I submit a PR?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/unicef/material-ui-currency-textfield/issues/18#issuecomment-823610474, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKMYSVK2GD2GIRB4LGGXBRTTJXWSNANCNFSM4KZGQ3FQ .

chitgoks commented 3 years ago

any prs?

JEAxero commented 2 years ago

I see that there's a PR in the queue to fix this. Any chance a maintainer can review and approve it? Thanks!

kenanerkorkmazmhp commented 1 year ago

37 fixes this issue. Can any maintainer review and approve it? Thanks in advance!