uniclogs / yamcs

Yamcs-based mission control software for UniClOGS

GNU Affero General Public License v3.0

1 stars 3 forks source link

GroundStation HMAC Support #29

Closed dmitri-mcguckin closed 2 years ago

dmitri-mcguckin commented 2 years ago

Features

Add post-processing-hook step to generate and append an HMAC key to the payload
Integrated Yamcs LoggingHandler + relevant configs into EdlPostProcessing hook
Reduced maximum file-name size from 32 bytes to 8 bytes

Bug Fixes

Replaced stale reference to encodeShort with encodeUnsignedShort which was crashing Yamcs in Java 11

To Do

Update secret loading to come from either the Yamcs central config, or an environment variable or something
Update syslogger.properties to point to /var/log instead

ryanpdx commented 2 years ago

I guess we can target this project to be for docker containers only. That would make the logging to /opts/ error go away. Also, this would allow us to configure yamcs to use persistent data (requires a absolute path (see comment src/main/yamcs/etc/yamcs.yaml).

dmitri-mcguckin commented 2 years ago

I think all you're missing is a bit of environment contex.

The logs happen to be in /opt because that's where my target install is at the moment.

The point is just that it's in the same directory as your install path.

Feel free to do so for your own and it should work then.

Though we could probably also move the log output to /var/log if we wanted to future proof some more.

The goal of this pr is not future proofing though, it's to get something working and ready for link testing asap.

dmitri-mcguckin commented 2 years ago

I don't think a docker container is strictly necessary, definitely not right now, because trying to support changing the xtce's and such and then all of that inside an image is more complexity we shouldn't add until yamcs is working.

ryanpdx commented 2 years ago

Okay, sounds good.

We should have the default settings log to the current working dir not /opt/ then, so it can run on anyones computer.