uniclogs / yamcs

Yamcs-based mission control software for UniClOGS
GNU Affero General Public License v3.0
1 stars 3 forks source link

Invalid Packet Length Hotfix #57

Closed dmitri-mcguckin closed 1 year ago

dmitri-mcguckin commented 1 year ago

Closes Issue #53

This is a hotfix for the BeaconPacketPreprocessor class as it assumes that anything arriving in the UDP port is the correct length.

I simply added an extra config for packetSize onto the packet-preprocessor args and a length check for each ingesting packet, if it is not the exact length, then the packet will be rejected, logged as such, and a warn event will be produced in the Yamcs event streamer.

While investigating this issue, more problematic issues with implementation came up.

In addition to other missing features, such as storing sequence numbers in YDB.

So a subsequent deeper-clean of all the Packet Config system will be needed.