unicode-org / icu-docker

Dockerfiles for ICU development
Other
6 stars 11 forks source link

workaround ICU not supporting git yet #8

Open srl295 opened 6 years ago

srl295 commented 6 years ago

Fixes: https://github.com/unicode-org/icu-docker/issues/7

I verified that this is able to create a near-identical icu4c 62.1 package. Differences are:

with this PR, make dist produces:

icu-r4a3ba8e-x86_64-pc-linux-gnu-Ubuntu-18.04-sdoc.tgz
icu-r4a3ba8e-x86_64-pc-linux-gnu-Ubuntu-18.04-src.d/icu4c-data-62_1-r4a3ba8e.zip
icu-r4a3ba8e-x86_64-pc-linux-gnu-Ubuntu-18.04-src.d/icu4c-docs-62_1-r4a3ba8e.zip
icu-r4a3ba8e-x86_64-pc-linux-gnu-Ubuntu-18.04-src.d/icu4c-src-62_1-r4a3ba8e.tgz
icu-r4a3ba8e-x86_64-pc-linux-gnu-Ubuntu-18.04-src.d/icu4c-src-62_1-r4a3ba8e.zip
icu-r4a3ba8eee9-x86_64-pc-linux-gnu-Fedora-28.tgz
icu-r4a3ba8eee9-x86_64-pc-linux-gnu-Fedora-28.tgz.md5
icu-r4a3ba8eee9-x86_64-pc-linux-gnu-Ubuntu-18.04.tgz
icu-r4a3ba8eee9-x86_64-pc-linux-gnu-Ubuntu-18.04.tgz.md5

… where the git hash https://github.com/unicode-org/icu/commit/4a3ba8eee90ea1414d4f7ee36563e6c9b28fda96 refers to the tag https://github.com/unicode-org/icu/releases/tag/release-62-1

CLAassistant commented 6 years ago

CLA assistant check
All committers have signed the CLA.

srl295 commented 5 years ago

@roubert is this superseded by #9 and #10 ?

roubert commented 5 years ago

@roubert is this superseded by #9 and #10 ?

The change to Makefile is now obsolete but the other changes replacing svnversion are still relevant.