Open sffc opened 8 months ago
My initial instinct was that it's tested by https://github.com/unicode-org/icu4x/blob/main/docs/tutorials/crates/baked/src/main.rs, but that only tests a single key. It does serve as an example why the tutorials are not good semver tests though :)
This isn't semver, though, being public API, it is certainly related. This is about making sure that we export as pub
and not pub(crate)
any APIs that databake-generated output needs.
Currently the
testdata-legacy
CI job fails when there is baked data that tries to access a pub(crate) API. It is the only CI that fails in this condition:https://github.com/unicode-org/icu4x/pull/4435
When we retire testdata we should continue testing for this condition, or else we may unintentionally land baked data APIs that don't work outside the crate.
CC @robertbastian