Open hsivonen opened 5 days ago
I agree there's room for improvement here. If icu_properties
is all singleton keys, we could likely drop the icu_locid_transform
dependency (note: crates are being reorganized in 2.0, but we wouldn't be able to entirely avoid the LocaleFallbacker dependency so long as we have exemplar chars, I think.
icu_locale
as a high level thing yes? We should boot this into there (and maybe feature gate it there)? Never made sense to me as a part of icu_properties
icu_properties
for lack of a better place. But now they can go into the icu_locale
data-driven crate.icu_locale
with an on-by-default feature. Can be kicked out into a separate crate if people need.icu_locale
has metacrate vibes to me, being proactive about features is good and helps avoid breaking --no-default-features
users_data
crates are completely insignificant for compile times.icu_locale
, though?Concrete proposal:
LGTM: @sffc @hsivonen
https://github.com/servo/rust-url/issues/939 shows the build of
icu_properties
blocking onicu_locid_transform
getting compiled. I gather the exemplar_chars module is the culprit.We should consider splitting the exemplar_chars module, which is locale-dependent CLDR data and not locale-independent Unicode Database data into a different crate.