search

unicode-org / icu4x

Solving i18n for client-side and resource-constrained environments.
https://icu4x.unicode.org
Other
1.29k stars 166 forks source link

Are `icu_pattern` and `icu_preferences` components or utils? #5179

Open robertbastian opened 4 days ago

robertbastian commented 4 days ago

These two crates currently live in utils and are not reexported in the meta crate, yet they use the icu_ prefix.

icu_pattern does not seem ICU-specific, it's just an encoding model for a pattern string. Maybe a name like zeropattern, which is in line with our other data representation crates zerovec and zerotrie, and calls out the zero-copy nature of the implementation, would be more appropriate.

Regarding icu_preferences, I think it should actually be a component, or live in the icu_locale component. If icu_locale is a component, this seems appropriate as a component as well.

robertbastian commented 4 days ago

Discuss with:

sffc commented 17 hours ago

I like zeropattern and icu::preferences or maybe icu::prefs