unicode-org / icu4x

Solving i18n for client-side and resource-constrained environments.
https://icu4x.unicode.org
Other
1.32k stars 172 forks source link

Move `icu_plurals::rules::reference` to datagen? #5181

Open robertbastian opened 1 month ago

robertbastian commented 1 month ago

Seems to be datagen-only code?

Both icu_plurals::rules and icu_datetime::pattern have parallel reference and runtime modules, presumably reference is not used at runtime?

sffc commented 1 month ago

@zbraniecki

sffc commented 1 month ago

In 2.0 I'm adding https://unicode-org.github.io/icu4x/rustdoc/icu_datetime/neo_pattern/struct.DateTimePattern.html which is a polished API around datetime::pattern::reference. I don't know if we need/want a public API around plurals::pattern::reference. I'm not super happy with it being doc(hidden).