search

unicode-org / icu4x

Solving i18n for client-side and resource-constrained environments.
https://icu4x.unicode.org
Other
1.37k stars 175 forks source link

Decide on names for icu_datetime and icu_calendar errors over FFI #5274

Open sffc opened 3 months ago

sffc commented 3 months ago

icu_datetime and icu_calendar have many new, small error enums. We should discuss their naming conventions.

One example which isn't super great is that icu_calendar::ParseError is currently exported as CalendarParseError, even though it is the error resulting from parsing an IXDTF string to a Date, Time, or DateTime. (https://github.com/unicode-org/icu4x/pull/5260)

sffc commented 3 months ago

I want to save this discussion until after neo datetime is fully landed so that we can see exactly which error enums we're having to name in FFI.

sffc commented 1 month ago

Part of the 2.0 FFI audit

sffc commented 2 weeks ago

@robertbastian says he's fine with names so long as they are targeted/descriptive as opposed to reliant on the crate name.