Serde impls for VarULE types (Var tuple types, and make_var)

unicode-org / icu4x

Solving i18n for client-side and resource-constrained environments.

https://icu4x.unicode.org

Other

1.38k stars 178 forks source link

Serde impls for VarULE types (Var tuple types, and make_var) #5802

Closed Manishearth closed 1 week ago

Manishearth commented 1 week ago

We were missing these.

This also gives me a much clearer idea of what's needed in https://github.com/unicode-org/icu4x/issues/5561. I might go and implement that, but I may also just use what we have for now for DecimalSymbolsV1.

Manishearth commented 1 week ago

Oh yeah I was planning to test more but it was becoming the weekend so i wrapped up.

I'll add tests and fix things when I get a chance.

Manishearth commented 1 week ago

Added some tests. We do keep hitting https://github.com/rust-lang/rust/issues/130180 :/