unicode-org / icu4x

Solving i18n for client-side and resource-constrained environments.
https://icu4x.unicode.org
Other
1.38k stars 178 forks source link

DateTime Options migration #5811

Closed sffc closed 1 week ago

sffc commented 1 week ago

1317

Removes the old options from datetime::options and moves the new options from datetime::neo_skeleton to datetime::options.

There is one change I am unsure about. Please take note of datetime::options::components moving to provider, despite it being returned by a pub fn in DateTimePattern.

Depends on #5807 Depends on #5814 Depends on #5817

dpulls[bot] commented 1 week ago

:tada: All dependencies have been resolved !

dpulls[bot] commented 1 week ago

:tada: All dependencies have been resolved !

sffc commented 1 week ago

There is one change I am unsure about. Please take note of datetime::options::components moving to provider, despite it being returned by a pub fn in DateTimePattern.

Working group discussion:

Conclusion: OK to put it in the provider module for now in 2.0