search

unicode-org / icu4x

Solving i18n for client-side and resource-constrained environments.
https://icu4x.unicode.org
Other
1.38k stars 178 forks source link

AnyCalendar locale constructor naming #5843

Open sffc opened 1 day ago

sffc commented 1 day ago

https://github.com/unicode-org/icu4x/pull/5842 changed the argument of AnyCalendar::new_for_locale to take AnyCalendarPreferences instead of Locale, but it did not change the name of the function.

Please note that there is already another function AnyCalendar::new that takes an AnyCalendarKind.

Should we:

  1. Leave things the way they are now
  2. Change the new function to work with preferences and change the AnyCalendarKind constructor to be new_for_kind
  3. Change new_for_locale to new_for_preferences
  4. Add new_for_preferences and keep new_for_locale the way it was before
  5. ?

I would rather not make this decision myself.

Needs input from: @zbraniecki @Manishearth and others

Manishearth commented 1 day ago

No strong preference, but: 4 ~> 2 ~> 3 ~> 1

zbraniecki commented 1 day ago

2 >> 3 >> 1 = 4