Closed markusicu closed 7 months ago
LGTM, however this is only necessary if you're planning to add to CONTRIBUTING.md, though, because by default you already get the inherited version (the URL is in the README and it is presented to users automatically when they open a PR).
If you're not planning on making any additional sections to this file, then there's no reason to copy it here.
Ok, I just assumed that a public repo should have a local copy of that file, so before making this repo public (as was approved) I was looking for what might still need to be done.
I will revert this then.
I haven't tried yet whether I have the power to make this repo public. I guess I will find out :-)
Do we have instructions for how to set up a new public repo? For example, how to set up the CLA assistant? The “... Internal Policies & Processes ...” doc says “Github does not make the CLA Assistant available in private repos”. Does it get auto-added when making the repo public?
Do we have instructions for how to set up a new public repo?
@srl295 In addition to the CLA setup, it would also be useful to document the need-no-local-contributing-file, the recommended branch protections, recommended repo settings in general, ...
The “Policy & Process for New Repos ...” doc does not seem to provide these details either. But maybe I am just blind.
Btw. the repo, right now, is set to private. Non Unicode members can't see it - could we convert it into public? (I don't have the power to do so from the Settings).
пет, 23. феб 2024. у 10:02 Markus Scherer @.***> је написао/ла:
Do we have instructions for how to set up a new public repo?
@srl295 https://github.com/srl295 In addition to the CLA setup, it would also be useful to document the need-no-local-contributing-file, the recommended branch protections, recommended repo settings in general, ...
The “Policy & Process for New Repos ...” doc does not seem to provide these details either. But maybe I am just blind.
— Reply to this email directly, view it on GitHub https://github.com/unicode-org/inflection/pull/2#issuecomment-1961766358, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA7GEKSZ4U7MOI767MMOXOLYVDKTBAVCNFSM6AAAAABDXCGRT6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRRG43DMMZVHA . You are receiving this because your review was requested.Message ID: @.***>
Or do we need to do more set up work to do so (like CLA requirement)?
пет, 23. феб 2024. у 10:04 Nebojša Ćirić @.***> је написао/ла:
Btw. the repo, right now, is set to private. Non Unicode members can't see it - could we convert it into public? (I don't have the power to do so from the Settings).
пет, 23. феб 2024. у 10:02 Markus Scherer @.***> је написао/ла:
Do we have instructions for how to set up a new public repo?
@srl295 https://github.com/srl295 In addition to the CLA setup, it would also be useful to document the need-no-local-contributing-file, the recommended branch protections, recommended repo settings in general, ...
The “Policy & Process for New Repos ...” doc does not seem to provide these details either. But maybe I am just blind.
— Reply to this email directly, view it on GitHub https://github.com/unicode-org/inflection/pull/2#issuecomment-1961766358, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA7GEKSZ4U7MOI767MMOXOLYVDKTBAVCNFSM6AAAAABDXCGRT6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRRG43DMMZVHA . You are receiving this because your review was requested.Message ID: @.***>
Or do we need to do more set up work to do so (like CLA requirement)?
Well, I just made it public, but when I go back to the branch protections, there are no "status checks" to select. @srl295 how do I set up the CLA assistant "status check"?
PS @nciric: It's much nicer to reply to GitHub comments from the GitHub UI. Replying by email is messy.
LGTM, however this is only necessary if you're planning to add to CONTRIBUTING.md, though, because by default you already get the inherited version (the URL is in the README and it is presented to users automatically when they open a PR). If you're not planning on making any additional sections to this file, then there's no reason to copy it here.
Ok, I just assumed that a public repo should have a local copy of that file, so before making this repo public (as was approved) I was looking for what might still need to be done.
Mostly just setting up the README and such.
I will revert this then.
or close it?
I haven't tried yet whether I have the power to make this repo public. I guess I will find out :-)
probably not, if not just let me know.
Do we have instructions for how to set up a new public repo? For example, how to set up the CLA assistant? The “... Internal Policies & Processes ...” doc says “Github does not make the CLA Assistant available in private repos”. Does it get auto-added when making the repo public?
The only instructions are to update the README which I've done.
CLA assistant is already setup organization wide, there's nothing that needs to be done there, other than branch protection to require PRs to pass the cla-assistant check. But i'd come knocking on the door here if that wasn't in place.
I haven't tried yet whether I have the power to make this repo public. I guess I will find out :-)
probably not, if not just let me know.
I did make it public.
CLA assistant is already setup organization wide, there's nothing that needs to be done there, other than branch protection to require PRs to pass the cla-assistant check. But i'd come knocking on the door here if that wasn't in place.
I went back to the main
branch protections and tried to turn on “Require status checks to pass before merging” but got
Is that expected because we do this for the whole org, not for each repo?
Or do we need to do more set up work to do so (like CLA requirement)?
Well, I just made it public, but when I go back to the branch protections, there are no "status checks" to select.
@srl295 how do I set up the CLA assistant "status check"?
Someone will have to open a PR so that it attempts to run the check.
The status checks to select option says something like "checks seen during the last week".
Copy from https://raw.githubusercontent.com/unicode-org/.github/main/.github/CONTRIBUTING.md