search

unicode-org / jira-github-pr-check

Checks GitHub pull requests for valid and accepted Jira tickets. Used for ICU and CLDR
Other
11 stars 12 forks source link

indicate if it's "rebase and merge" ready? #3

Closed srl295 closed 5 years ago

srl295 commented 6 years ago

Could the hook indicate whether all commits are eligible for a "rebase and merge"? i.e. if they all mention the same JIRA id AND include the PR URL?

srl295 commented 6 years ago

^ really, it's a small step from here to just asking the hook to do exactly the kind of merge we want, and FIX the commits.

sffc commented 6 years ago

Yeah, this is a good idea. However, would you want the check to fail if the commits are not well-formed? The downside is that this would require the author to amend (rebase) their commit messages.

What I mean is, checks either pass or fail. Technically, there are 4 statuses:

We can always add information to the description string, but if the check passes (success status), there isn't like an in-your-face alert to inform you that there might be a problem.

sffc commented 5 years ago

The latest changes look at commit message formats and enforce them.