search

unicode-rs / unicode-security

Detect possible security problems with Unicode usage according to Unicode Technical Standard #39 rules.
Other
14 stars 4 forks source link

Add mixed-script detection #6

Closed Manishearth closed 4 years ago

Manishearth commented 4 years ago

Yes, I'm using a git dependency right now, because the crate name is taken, but I have push access to the old crate and would rather just update it (see https://github.com/servo/unicode-script/issues/6)

For prototyping this should be fine.

We should also move identifier profile stuff into a different module as well.

r? @crlf0710

crlf0710 commented 4 years ago

Seems diverted a little from the original specification since there's no handling of the Zyyy and Zinh. (Maybe that's intentional, then maybe document it a little?)

And maybe you want to bikeshed a little on the module name mixed(maybe mixed_script?) and the trait name UnicodeMixedScript (the Unicode prefix feels a little redundant).

Otherwise looks good to me.

Manishearth commented 4 years ago

@crlf0710 Zyyy and Zinh are already handled by the unicode-script crate. I'll leave a comment

Heh, I realized I should rename it and did so before seeing your comment. I've also moved the identifier status stuff into its own similarly-named module. I don't have strong opinions about the name.

Manishearth commented 4 years ago

Actually, no, I hadn't gotten the Zyyy/Zinh stuff exactly right. I'll fix