search

unicode-rs / unicode-xid

Other
49 stars 28 forks source link

The `no_std` feature has no effect #30

Open Liamolucko opened 2 years ago

Liamolucko commented 2 years ago

The no_std feature has no effect, because #![no_std] is unconditionally enabled (as it should be, since this crate has no reliance on std). It seems like this became the case in 02cc96c735177116885a5a2d410de4a7781ac7c3.

It should be removed or deprecated (probably deprecated, to avoid the breaking change), and the docs should reflect that #![no_std] is always enabled.

Manishearth commented 2 years ago

I think we had it in there for backcompat, but we can mark it as deprecated