Open bosunski opened 5 years ago
@unicodeveloper Awaiting Review.
@bosunski As a maintainer of a popular package, I can tell you it's not likely this PR will get reviewed. It's time-consuming work with a lot of mental overhead, and my guess is @unicodeveloper doesn't make use of this package himself anymore. I suggest you message him and ask him to make you a maintainer, so you can have merge and release rights. Then you can do ahead to revamp and improve the package as you'd like.
Thanks, @shalvah. I tried to DM on twitter though, its closed for now.
Thanks for the PR @bosunski. This is a lot of changes 😄
I'd try to take a look at it over the weekend.
@bosunski 👏 Nice! Great stuff! Especially that easy swap between test and live mode. Tempted to use yours pending when Uncle P reviews and possibly merge.
@unicodeveloper still waiting on you.
I really like the simplicity of paystack and of course laravel and this package is a bridge between them. I found out I kept adding lots of changes to the package when I see fit so I decided to have a major rewrite for it. Maybe from there, it can open more possibility for it. Looking at it, this is a Major change in the project maybe it should be tagged
v2.0
or something.😁Let's go straight to the point!
Summary Of changes
xeviant/paystack
packagexeviant/paystack
package which provides it all of paystack.Testing Instruction
To test this in a Laravel Project, while it's not merged, do this:
composer.json
It will install this PR and then you can run:
In the prompt choose option for
Unicodeveloper\Paystack\PaystackServiceProvider
And then you can continue normal configuration and test.