unicodeveloper / laravel-paystack

:credit_card: :package: :moneybag: Laravel 6, 7, 8, 9, 10 and 11 Package for Paystack
https://paystack.co
MIT License
605 stars 312 forks source link

Rewrote the Project for better support and possibilities. #71

Open bosunski opened 5 years ago

bosunski commented 5 years ago

I really like the simplicity of paystack and of course laravel and this package is a bridge between them. I found out I kept adding lots of changes to the package when I see fit so I decided to have a major rewrite for it. Maybe from there, it can open more possibility for it. Looking at it, this is a Major change in the project maybe it should be tagged v2.0 or something.

😁Let's go straight to the point!

Summary Of changes

Testing Instruction

To test this in a Laravel Project, while it's not merged, do this:

It will install this PR and then you can run:

php artisan vendor:publish

In the prompt choose option for Unicodeveloper\Paystack\PaystackServiceProvider

And then you can continue normal configuration and test.

Dancer-Thank-You

bosunski commented 5 years ago

@unicodeveloper Awaiting Review.

shalvah commented 5 years ago

@bosunski As a maintainer of a popular package, I can tell you it's not likely this PR will get reviewed. It's time-consuming work with a lot of mental overhead, and my guess is @unicodeveloper doesn't make use of this package himself anymore. I suggest you message him and ask him to make you a maintainer, so you can have merge and release rights. Then you can do ahead to revamp and improve the package as you'd like.

bosunski commented 5 years ago

Thanks, @shalvah. I tried to DM on twitter though, its closed for now.

unicodeveloper commented 5 years ago

Thanks for the PR @bosunski. This is a lot of changes 😄

I'd try to take a look at it over the weekend.

aeadedoyin commented 5 years ago

@bosunski 👏 Nice! Great stuff! Especially that easy swap between test and live mode. Tempted to use yours pending when Uncle P reviews and possibly merge.

bosunski commented 5 years ago

@unicodeveloper still waiting on you.