search

uniconproject / unicon

http://www.unicon.org
Other
54 stars 28 forks source link

1st draft of the Heap Verification routines. #48

Closed Don-Ward closed 4 years ago

Don-Ward commented 4 years ago

All verification is controlled by an environment variable VRFY. Some structures, notably lists, are not verified yet. See rmemmgt.r for details.

Jafaral commented 4 years ago

@Don-Ward if you want the code under your new VerifyHeap to be CI tested on github without messing with the CI test itself , you can do the trick of defining VerifyHeap in define.h as part of the the commit and push it to a temporary branch on your sandbox.

Jafaral commented 4 years ago

Just did that here: https://github.com/Jafaral/unicon/commit/59775d1f4d538059a4eb25543ff567dfec056209

Jafaral commented 4 years ago

Test failed on Ubuntu: https://github.com/Jafaral/unicon/runs/650353668?check_suite_focus=true

Don-Ward commented 4 years ago

The error happens on the Ubuntu build because the verifier code references something that is not defined when we are building iconc (i.e. when COMPILER is defined). I removed the offending code in commit 7eb3098.

A more interesting question is why the macOS build does not build iconc.

Jafaral commented 4 years ago

For bookkeeping it is probably good to say why we are closing this one and not merging, something like:

Merged with #49