search

uniconproject / unicon

http://www.unicon.org
Other
57 stars 28 forks source link

Add a ThreadPool class to the threads package. #490

Open Don-Ward opened 2 days ago

Don-Ward commented 2 days ago

The new class is documented in Appendix C of the Unicon book. A test has been added to tests/threads.

Jafaral commented 2 hours ago

I have't gotten a chance to review this yet. However, it is good to have separate commits for tests and documentation updates. This PR can be split to 3 commits.

Don-Ward commented 1 hour ago

I have't gotten a chance to review this yet. However, it is good to have separate commits for tests and documentation updates. This PR can be split to 3 commits.

Any commit that adds something new can be split up into "Add a thing", "Document the thing" and "Test the thing", but it is completely unclear to me why that is better. Splittting it up means that individual commits can be reverted, but why would you revert the addition without also reverting the testing or documentation? In short, I don't understand the benefits of separating documentation and testing from the addition of the thing itself.