Implemented optional pointer for providing register size to operations

unicorn-engine / unicorn

Unicorn CPU emulator framework (ARM, AArch64, M68K, Mips, Sparc, PowerPC, RiscV, S390x, TriCore, X86)

http://www.unicorn-engine.org

GNU General Public License v2.0

7.33k stars 1.31k forks source link

Closed BitMaskMixer closed 8 months ago

BitMaskMixer commented 8 months ago

This shall prevent buffer overflows during usage of too small variables for these functions.
A macro has been added to check the correct register size - and currently used as POC for ARM 32 only
The cpp tests are changed too, to demonstrate the usage.
Breaking change: Bindings must reflect these changes

wtdcode commented 8 months ago

Thanks for your interest. We did this already in dev branch via https://github.com/unicorn-engine/unicorn/commit/4055a5ab109c1d8d2da06515f3e117ca57faf179. Does that address your concern?

BitMaskMixer commented 8 months ago

Alright - did not check was going on the dev branch. Thanks.