Fix emulator detection - Githubissues

mrexodia commented 1 week ago

References:

This fixes the bswap ax detection as well as various other detections related to bad REX prefix handling. This bug is also still upstream in qemu, but they moved the code around quite a bit:

https://github.com/qemu/qemu/blob/ffeddb979400b1580ad28acbee09b6f971c3912d/target/i386/tcg/decode-new.c.inc#L2561-L2570

There are two fixes here:

bswap ax now correctly sets ax to zero
REX prefixes are correctly ignored when appropriate (they only apply when they are right next to the first byte of the instruction)

mrexodia commented 1 week ago

The build errors on macos are also present on the main branch. No idea about the crash for MINGW64, help would be appreciated!

wtdcode commented 1 week ago

MINGW64 errors is just random crashing which I can’t reproduce locally.

macOS is probably due to system upgraded.

From: Duncan Ogilvie @.> Sent: Monday, June 24, 2024 3:31:17 AM To: unicorn-engine/unicorn @.> Cc: Subscribed @.***> Subject: Re: [unicorn-engine/unicorn] Fix emulator detection (PR #1966)

The build errors on macos are also present on the main branch. No idea about the crash for MINGW64, help would be appreciated!

― Reply to this email directly, view it on GitHubhttps://github.com/unicorn-engine/unicorn/pull/1966#issuecomment-2185279355, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AHJULO5L6GTEEJFAQX3RE63ZI4PALAVCNFSM6AAAAABJXSSZIGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBVGI3TSMZVGU. You are receiving this because you are subscribed to this thread.Message ID: @.***>

unicorn-engine / unicorn

Fix emulator detection #1966