ZakDanger
commented
7 years ago Wow well after much work I have the x86_x64-softmmu specific part of unicorn enigne building in msvc.
One thing that I still need to fix is the atomic operations. I haven't had experience with this before and from reading about it, it sounds like something that I could do incorrectly and then cause weird random bugs that are hard to track down. So I am hoping someone can help me implement these correctly:
1)
/* Compiler barrier */
#ifdef _MSC_VER
// TODO: fix me!!!
#define barrier() //{ __asm volatile("" ::: "memory"); (void)0; }
#else
#define barrier() ({ asm volatile("" ::: "memory"); (void)0; })
#endif2)
#if defined __x86_64__
# ifdef _MSC_VER
// TODO: fix me!!!
# define smp_mb() //{ __asm volatile("mfence" ::: "memory"); (void)0; }
# else
# define smp_mb() ({ asm volatile("mfence" ::: "memory"); (void)0; })
# endif
#else
# ifdef _MSC_VER
// TODO: fix me!!!
# define smp_mb() //{ __asm volatile("lock; addl $0,0(%esp) " ::: "memory"); (void)0; }
# else
# define smp_mb() ({ asm volatile("lock; addl $0,0(%%esp) " ::: "memory"); (void)0; })
# endif
#endif
aquynh
Nukem9
cseagle
stephengroat
I am opening this issue as a place to pose questions during the port of unicorn to MSVC.