search

unicorn-fail / dreditor.org

Dreditor Browser Extension Site
https://dreditor.org
GNU General Public License v2.0
0 stars 1 forks source link

Filter out PRs that aren't against HEAD (1.x currently) #13

Open markhalliwell opened 10 years ago

markhalliwell commented 10 years ago

Feature branches on dreditor/dreditor that also have PRs show up as "branches" in the autobuilds list. This can confuse users as to which one they should use.

Feature branches themselves have to be manually rebased. This causes the build to technically be behind HEAD. Whereas the PR build is usually at a "mergeable" state (auto-rebased by GH) until it actually really needs to be rebased again.

markhalliwell commented 10 years ago

Comparing these PRs:

dreditor/dreditor/chrome-autoload https://api.github.com/repos/dreditor/dreditor/pulls/140

@sun's sun/dreditor/smart-commits https://api.github.com/repos/dreditor/dreditor/pulls/146

Looks like we can just filter out the branches on whether any PRs match $pr['head']['repo']['owner']['login'] === 'dreditor' and $pr['head']['ref'] === $branch['name'].

markhalliwell commented 10 years ago

Actually, we can just filter out PRs that aren't currently HEAD (1.x currently).

markhalliwell commented 10 years ago

sigh

PRs have the auto-rebase by GH, so I'll have to go with my original idea.