unicorn-fail / dreditor.org

Dreditor Browser Extension Site
https://dreditor.org
GNU General Public License v2.0
0 stars 1 forks source link

Cannot install fresh copy on Firefox (error message about an old GreaseMonkey version of Dreditor being installed) #16

Closed DavidRothstein closed 9 years ago

DavidRothstein commented 9 years ago

Following https://github.com/dreditor/dreditor.org/issues/15 it's possible to do a fresh install of Dreditor on Chrome, but not Firefox.

On Firefox I get an error message about "An old GreaseMonkey user script version of Dreditor is installed."

Looking at the code it probably is due to this:

if ($.browser.mozilla && installedVersion <= '1.2.3') {
  installedVersion = '0.0.1';
}

Followed by this later on:

if (installedVersion === "0.0.1") {
  installText = 'An old GreaseMonkey user script version of Dreditor is installed.<br /><small>(Remove the GreaseMonkey user script and reload this page)</small>.';

Probably the first one should skip running if installedVersion is '0.0.0'?

DavidRothstein commented 9 years ago

Works great now, thanks again :)