search

unicorn-fail / dreditor

The "Dreditor" browser extension for Drupal.org.
https://www.drupal.org/project/dreditor
GNU General Public License v2.0
72 stars 36 forks source link

The 80 chars guide is 1 char to the left #260

Closed claudiu-cristea closed 9 years ago

claudiu-cristea commented 9 years ago

As we are reviewing patches and patches lines have 1 char prefix, the vertical guide must be draw after the 81st character. Right now it's drawn after 80 chars and this can lead to the conclusion that some lines are not correctly wrapped.

The snapshot example is from https://www.drupal.org/node/2281533#comment-10201329

80chars
star-szr commented 9 years ago

I think I narrowed it down to when a new file is added that is 100 lines or more, and when no changes are made to other files outside of the first 99 lines. The ruler calculation falls apart in that situation, looking at the code now.

star-szr commented 9 years ago

This is fixed in Dreditor 1.2.15 which was just released. Thanks for the report!