Closed sja45uk closed 9 years ago
star-szr
commented
9 years ago Hi @sja45uk, thanks for the suggestion! At this time we're generally not interested in adding these types of tweaks to Dreditor itself, it's much easier these days to get these types of changes into drupal.org directly where everyone can use them, regardless of whether they use Dreditor (or whether their browser/device even supports browser extensions).
sja45uk
commented
9 years ago Makes sense to put something into the base page, but I am not sure how easy that will be to achieve as it affects all visitors. Is it feasible for me to fork dreditor to introduce an experimental change to help me decide if an additional link from each comment would be useful.
Sent from my Windows Phone
From: Scott Reevesmailto:notifications@github.com Sent: 19/10/2015 22:01 To: unicorn-fail/dreditormailto:dreditor@noreply.github.com Cc: Stevemailto:sja45uk@msn.com Subject: Re: [dreditor] Provide link from comment #1 to current issue summary (#271)
Hi @sja45uk, thanks for the suggestion! At this time we're generally not interested in adding these types of tweaks to Dreditor itself, it's much easier these days to get these types of changes into drupal.org directly where everyone can use them, regardless of whether they use Dreditor (or whether their browser/device even supports browser extensions).
Reply to this email directly or view it on GitHub: https://github.com/unicorn-fail/dreditor/issues/271#issuecomment-149346093
star-szr
commented
9 years ago I'm a bit confused now I thought this was just for comment #1 based on your description. So is it more of a "back to top" link?
Yes, it's easy to fork this repository and there are instructions for building the code into extensions in CONTRIBUTING.md.
sja45uk
commented
9 years ago Scott - My original requirement was to go from the Comment #1 up to the issue summary. It became apparent to me from your reply that there were two options: change D.o issue display; or change dreditor. As I thought further about a fork to dreditor, I decided that a back to issue summary from every comment would probably better meet my needs. So the inevitable requirements drift has struck. Steve
From: Scott Reeves [mailto:notifications@github.com] Sent: 20 October 2015 12:41 To: unicorn-fail/dreditor Cc: Steve Subject: Re: [dreditor] Provide link from comment #1 to current issue summary (#271)
I'm a bit confused now I thought this was just for comment #1 https://github.com/unicorn-fail/dreditor/issues/1 based on your description. So is it more of a "back to top" link?
Yes, it's easy to fork this repository and there are instructions for building the code into extensions in CONTRIBUTING.md.
— Reply to this email directly or view it on GitHub https://github.com/unicorn-fail/dreditor/issues/271#issuecomment-149535375 . https://github.com/notifications/beacon/AC2oPw6k1YCS_6hYHliV0fy88-x1w6WIks5o9h_fgaJpZM4GRM5z.gif
star-szr
commented
9 years ago Gotcha. I know it's not quite the same but don't most browsers let you go to to the top of the page by pressing Home on the keyboard?
sja45uk
commented
9 years ago I guess I should try Home then PgDn to see if it satisfies the use case. Unfortunately the Issue Summary starts more than half way down the screen.
From: Scott Reeves [mailto:notifications@github.com] Sent: 20 October 2015 18:01 To: unicorn-fail/dreditor Cc: Steve Subject: Re: [dreditor] Provide link from comment #1 to current issue summary (#271)
Gotcha. I know it's not quite the same but don't most browsers let you go to to the top of the page by pressing Home on the keyboard?
— Reply to this email directly or view it on GitHub https://github.com/unicorn-fail/dreditor/issues/271#issuecomment-149633167 . https://github.com/notifications/beacon/AC2oP4wUbcR90Fu5JI_BY2rPtGi9w-tYks5o9mrMgaJpZM4GRM5z.gif
When reviewing the issue queue, the Summary field links to the top of the issue page. If the issue has been updated then the "N new" in the Replies field links to the #new comment. It would be helpful (when viewing an issue that has not been viewed before) if the comment #1 gave easy access to the start of the issue summary. Perhaps the dreditor could provide a link from comment #1 to the "page-subtitle" h1 tag. This would avoid the need to unnecessarily scroll the browser to view the summary.