unicorn-fail / dreditor

The "Dreditor" browser extension for Drupal.org.
https://www.drupal.org/project/dreditor
GNU General Public License v2.0
72 stars 36 forks source link

Support colorize-words. #279

Closed lokapujya closed 8 years ago

lokapujya commented 8 years ago

My CSS isn't applying.

markhalliwell commented 8 years ago

Ultimately I'm closing this because it has no real benefit. No one in the d.o community actually uses word diffs.

Furthermore, there's too much ambiguity for when this would actually apply since there are many different methods for --word-diff[=].

If Dreditor is ever to have a word diff level of syntax, it would need to be done consistently and reliably by a server, not user provided patches.

lokapujya commented 8 years ago

That makes sense. Although, it was a pain to review this issue: https://www.drupal.org/node/2572545 because the help text was on one big long line and so the changes were easier to review with the word diff.

I had no expectations to actually merge this feature. I mostly did it just to play around with the Dreditor code/grunt.