unidoc / unipdf

Golang PDF library for creating and processing PDF files (pure go)
https://unidoc.io
Other
2.61k stars 254 forks source link

[BUG] Incorrect text show operator symbol, two single quotes vs double quote #287

Closed AdamSLevy closed 4 years ago

AdamSLevy commented 4 years ago

Description

The text show operator " is a double quote, not two single quotes. The code is incorrectly using two single quotes in two places:

https://github.com/unidoc/unipdf/blob/ed30fe63f3b0e2b0488c5dd48b11bc518a930504/render/renderer.go#L890 https://github.com/unidoc/unipdf/blob/ed30fe63f3b0e2b0488c5dd48b11bc518a930504/render/internal/context/text_state.go#L131 https://github.com/unidoc/unipdf/blob/ed30fe63f3b0e2b0488c5dd48b11bc518a930504/contentstream/operand_list.go#L89

Expected Behavior

The " operator should be detected by the renderer, but it is not because it is searching for two single quotes. This will cause incorrect rendering for this operator.

github-actions[bot] commented 4 years ago

Welcome! Thanks for posting your first issue. The way things work here is that while customer issues are prioritized, other issues go into our backlog where they are assessed and fitted into the roadmap when suitable. If you need to get this done, consider buying a license which also enables you to use it in your commercial products. More information can be found on https://unidoc.io/