unidoc / unipdf

Golang PDF library for creating and processing PDF files (pure go)
https://unidoc.io
Other
2.5k stars 249 forks source link

Use page indirect object for internal outline destinations #359

Closed adrg closed 4 years ago

adrg commented 4 years ago

This change is Reviewable

codecov[bot] commented 4 years ago

Codecov Report

Merging #359 into development will increase coverage by 3.90%. The diff coverage is 78.12%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #359      +/-   ##
===============================================
+ Coverage        52.61%   56.51%   +3.90%     
===============================================
  Files              236      236              
  Lines            45772    45790      +18     
===============================================
+ Hits             24081    25880    +1799     
+ Misses           18587    16572    -2015     
- Partials          3104     3338     +234     
Impacted Files Coverage Δ
creator/creator.go 69.48% <63.63%> (-0.61%) :arrow_down:
model/outline.go 72.10% <85.71%> (+3.21%) :arrow_up:
internal/jbig2/document/segments/text-region.go 41.05% <0.00%> (+0.22%) :arrow_up:
...ernal/jbig2/document/segments/symbol-dictionary.go 38.49% <0.00%> (+0.23%) :arrow_up:
internal/jbig2/bitmap/bitmap.go 76.76% <0.00%> (+0.28%) :arrow_up:
model/writer.go 75.63% <0.00%> (+0.42%) :arrow_up:
internal/jbig2/document/segments/generic-region.go 47.75% <0.00%> (+1.18%) :arrow_up:
fdf/parser.go 40.27% <0.00%> (+1.38%) :arrow_up:
internal/jbig2/document/segments/kind.go 11.59% <0.00%> (+1.44%) :arrow_up:
... and 52 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 033f410...b2f8e42. Read the comment docs.