unifhy-org / unifhy

A Unified Framework for Hydrology
https://unifhy-org.github.io/unifhy
BSD 3-Clause "New" or "Revised" License
11 stars 5 forks source link

Implement new constraints on component spatial and temporal resolutions #67

Closed ThibHlln closed 2 years ago

ThibHlln commented 2 years ago

resolve #64

This PR implements the stricter constraints decided on the temporal and spatial resolutions for the components of a model, i.e. the slower/coarser resolutions must be integer multiples of the faster/finer resolution(s).

The methods checking the domain compatibilities in Clock and Compass are updated to check for these new constraints. In doing so, the Grid is given a new method is_matched_in to determine whether the grid cells of a domain are contained in the grid cells of another (while waiting for a proper supermesh technique to be implemented).

The test suites are updated to comply with these new constraints. The resolutions of the dummy components are modified as follows:

The expected records are also modified since the change in temporal resolutions results in different numerical results.

The documentation is also updated to reflect those changes.