Address reviewers comments for publication in GMD (gmd-2021-419) - Githubissues

unifhy-org / unifhy

A Unified Framework for Hydrology

https://unifhy-org.github.io/unifhy

BSD 3-Clause "New" or "Revised" License

11 stars 5 forks source link

Address reviewers comments for publication in GMD (gmd-2021-419) #81

Closed ThibHlln closed 2 years ago

ThibHlln commented 2 years ago

This PR specifically addresses the reviewers' comments following our submission to GMD (https://doi.org/10.5194/gmd-2021-419).

Specifically, the following changes have been made:

add data to run tutorial and revise tutorial accordingly
revise installation instructions to recommend conda over pip because of esmpy dependency not available on PyPI

In the process, some other issues have arisen and were addressed:

fix intermittent data filenames loss in YAML configuration file (resolve #80)
fix relative import bug for advanced test suite (resolve #82)
prevent unwanted installation of tests package alongside unifhy (resolve #83)