unifi-utilities / unifios-utilities

A collection of enhancements for UnifiOS based devices
GNU General Public License v3.0
3.86k stars 415 forks source link

Support for UbiOS 2.5.x+ #498

Closed kb9gxk closed 1 year ago

kb9gxk commented 1 year ago

Most scripts are starting with #!/bin/sh

The newer systems are linking /bin/sh to /bin/dash

To fix the issue, scripts need to be adjusted to #!/bin/bash to work correctly.

boostchicken commented 1 year ago

sh is still on 2.5.x isnt it? I just upgraded and installed podman on a UDM PRO, podman needs a little more process but udm-boot-2x 101 deb works great and does use bash

boostchicken commented 1 year ago

I just confirmed that /bin/sh is on 2.5.x I am still happy to have it moved to bash or zsh as sh sucks,

boostchicken commented 1 year ago

https://github.com/unifi-utilities/unifios-utilities/pull/499

boostchicken commented 1 year ago

Please review the PR, once someone else reviews it ill merge

kb9gxk commented 1 year ago

I just confirmed that /bin/sh is on 2.5.x I am still happy to have it moved to bash or zsh as sh sucks,

Yes /bin/sh is still on 2.5.x, but if you do a ls -al /bin/sh, you'll find that it points to /bin/dash

Thank you for agreeing to move it. It will help so many people when the 2.5.x goes GA

boostchicken commented 1 year ago

Roger that thanks for clarification. Go review my PR and ill merge it

499

boostchicken commented 1 year ago

Merged