search

unifi-utilities / unifios-utilities

A collection of enhancements for UnifiOS based devices
GNU General Public License v3.0
3.83k stars 415 forks source link

on-boot-script vs on-boot-script-2.x #566

Open ddkedr opened 10 months ago

ddkedr commented 10 months ago

Hey, Guys!

Can anybody tell whether I should use on-boot-script or on-boot-script-2.x for my UDMP with UnifiOS 3?

And what is the actual difference between these two?

Thanks

m4n63 commented 10 months ago

Hey, Guys!

Can anybody tell whether I should use on-boot-script or on-boot-script-2.x for my UDMP with UnifiOS 3?

And what is the actual difference between these two?

Thanks

you need to use the 2.x version, and even that has some installation issues, read this topic for the rundown of the changes you need to perform manually after install. https://github.com/unifi-utilities/unifios-utilities/issues/501

fdcastel commented 9 months ago

Minor suggestions:

1) What about call it on-boot-script-3.x, then? Keep the versions aligned with Unifi OS base version. It would surely help to clear the confusion for new users.

2) Improve main README.md explaining the differences. As it is today there is no clear mention about the two versions. Worse: current section for 2.x wrongly points to README.md of 1.x (!?) 😟

Follow this readme.

3) Put an explicit warning in the README.md of each script version telling to use the other version (according to your Unifi OS version).

fdcastel commented 9 months ago

Other problems:

1) In 2.x docs the section Manual install steps are completely wrong for 3.x version. e.g. there is no unifi-os anymore.

2) Also: it tells to download a udm-boot-2x_1.0.1_all.deb package but links it to the wrong version (1.0.0). The sample code which follows the instruction also refers to the 1.0.0 version:

    curl -L [[https://udm-boot.boostchicken.dev](https://unifi.boostchicken.io/udm-boot-2x_1.0.0_all.deb)](https://unifi.boostchicken.io/udm-boot-2x_1.0.0_all.deb) -o udm-boot-2x_1.0.0_all.deb
    dpkg -i udm-boot-2x_1.0.0_all.deb
    systemctl enable udm-boot
    exit
fdcastel commented 9 months ago

For reference:

After reading #501 I did these steps to install on-boot-script in a UDM-PRO 3.x.

fdcastel commented 4 months ago

@boostchicken Any comments about the suggestions and problems cited above?

boostchicken commented 4 months ago

Send a PR and I;; review, or if you want a whole new repo Ill make you one.

SamErde commented 4 months ago

Actually...there might be something to maintaining a separate repo for the branch & package that supports older firmware with unifi-os and podman. I wonder if that would clear up the questions that continue to show up in issues.

fdcastel commented 4 months ago

Actually...there might be something to maintaining a separate repo for the branch & package that supports older firmware with unifi-os and podman.

I was thinking exactly this now.

@boostchicken What about to create a new 3.x repo in https://github.com/unifi-utilities/unifi-common (which is currently empty)?

boostchicken commented 1 month ago

Actually...there might be something to maintaining a separate repo for the branch & package that supports older firmware with unifi-os and podman. I wonder if that would clear up the questions that continue to show up in issues.

There is a branch 1.0.6 for old stuff

fdcastel commented 1 month ago

Send a PR and I;; review, or if you want a whole new repo Ill make you one.

Sorry guys. Somehow, I managed to completely miss this one.

I have an extra UDM-PRO around here.

I'll try to put some ideas up, and I'll send them to you, @boostchicken.

fdcastel commented 1 month ago

Actually...there might be something to maintaining a separate repo for the branch & package that supports older firmware with unifi-os and podman.

I was thinking exactly this now.

@boostchicken What about to create a new 3.x repo in https://github.com/unifi-utilities/unifi-common (which is currently empty)?

BTW: Do you have any plans for this one?

fdcastel commented 1 month ago

Forget it. I did just read this.

Man...

fdcastel commented 1 month ago

@boostchicken Did you ever attempt to boot an UDM-Pro firmware in a virtual environment (e.g. QEMU?)

boostchicken commented 1 month ago

@boostchicken Did you ever attempt to boot an UDM-Pro firmware in a virtual environment (e.g. QEMU?)

Hella yeah we did, their kernel didn't have the required stuff and we never got past that

boostchicken commented 1 month ago

Btw look at the commits I fixed a ton of issues related to 4.0 and just little things and also merged forks who had some fixes as well!