search

unified-font-object / ufoLib

A low-level UFO reader and writer.
Other
37 stars 19 forks source link

XML header changed #158

Closed miguelsousa closed 6 years ago

miguelsousa commented 6 years ago

The move to lxml library introduced changes to the XML header.

ufoLib 2.1.1

<?xml version="1.0" encoding="UTF-8"?>

ufoLib 2.2.4

<?xml version='1.0' encoding='utf-8'?>
anthrotype commented 6 years ago

We are still in time to fix this (after all, a third release in a week, we can do four). We can tell lxml to not add the xml_declaration=False, and prepend it ourselves (with double quotes) to the string that lxml generates. Shall i do it?

miguelsousa commented 6 years ago

Let me first test if any other changes were introduced. If they were then there's no point in bending backwards just because of the header.