always use Unix LF end of lines

unified-font-object / ufoNormalizer

A tool that will normalize the XML and other data inside of a UFO.

Other

51 stars 19 forks source link

always use Unix LF end of lines #30

Closed anthrotype closed 8 years ago

anthrotype commented 8 years ago

Since we are writing files in "text" mode, by default Python uses the native os.linesep, which on Windows is CR+LF ("\r\n").

We want all line endings to be normalized as Unix line feeds. By passing a newline="\n" argument to io.open, we make sure this is the case on every platform, including Windows.

/cc @moyogo

coveralls commented 8 years ago

Coverage increased (+0.03%) to 91.667% when pulling 3160ae4c72267498cbbb8bb0122b9bef953bd4ce on daltonmaag:lf-eol into 58ab51f8d90ae0d3cae31416cace5c5dcca4ba45 on unified-font-object:master.

anthrotype commented 8 years ago

BTW, the Appveyor build did not start automatically -- and actually that was the most important one to check since this patch is kind of Windows specific... (the tests do pass on my local Windows machine).

On the front page of ufoNormalizer, the Appveyor badge is pointing to an Appveyor account owned by @miguelsousa: https://ci.appveyor.com/project/miguelsousa/ufonormalizer/history

Maybe it needs to be @typesupply who needs to set up Appveyor for this repo? I'm not sure...