unified-font-object / ufoNormalizer

A tool that will normalize the XML and other data inside of a UFO.
Other
51 stars 19 forks source link

Turn off modification times by default #43

Open madig opened 6 years ago

madig commented 6 years ago

I regularly trip over this because I forget using the -m parameter, and using it won't erase the mod times already written to disk. Since a normalizer should normalize and not jot down mod times, I petition to turn it off by default.

anthrotype commented 6 years ago

I agree. Also because the main use case for the normalizer IMO is to avoid unnecessary diffs when the UFOs are under git version control. And the modification timestamps change by definition all the time.

miguelsousa commented 6 years ago

I'm not opposed to that change, but I'd like to hear other people's opinion first. I understand the motivation — I added the -m option and use it pretty much every time to avoid the diff as well — but the time stamps serve a real purpose: make re-normalization faster. I wished there was a way to save the mod times in a separate file which could then be git-ignored. This way we'd get its benefits without interfering with the diff.

madig commented 6 years ago

Isn't that file called layerinfo.plist? ;)

anthrotype commented 6 years ago

No because layerinfo is part of the ufo source, and should not be gitignored. We can store them next to the ufo, and name the dotfile with the same name as the ufo it is normalising

anthrotype commented 6 years ago

Or maybe in the data folder would be better (ufo3 only)

miguelsousa commented 6 years ago

I like the data folder idea.