search

unified-font-object / ufoNormalizer

A tool that will normalize the XML and other data inside of a UFO.
Other
51 stars 19 forks source link

Address Python 3.9 plistlib changes #74

Closed josh-hadley closed 3 years ago

josh-hadley commented 3 years ago

closes #73

anthrotype commented 3 years ago

Python 3.5 is EOL, it can be safely dropped by now

josh-hadley commented 3 years ago

@anthrotype @benkiel and anyone else who wants to chime in: I made the changes requested (and more). The Travis check on Python 3.8 is failing in a very odd way that I don't really understand. I can't repro it here, some weird glitch. I think it's okay so hoping you can overlook that in your review. Related: Ben has given me admin access, which I'll use to implement GitHub Actions and ditch TravisCI once this PR is sorted.

benkiel commented 3 years ago

@josh-hadley this looks good to me, and yes that Python 3.8 error is super weird, will overlook. Going to merge this, once GhitHub actions is in place we can cut a release. Thank you so much for taking care of this.

josh-hadley commented 3 years ago

Sure thing, @benkiel . If someone from the unified-font-object org can add org- or repo-level secrets with the PyPI token (as e.g. PYPI_PASSWORD) I can set up a few GitHub Action workflows for testing, making a release (including publishing to PyPI). I've set this up for our AFDKO and psautohint repos and it's super-handy; basically all you have to do to make a release is push a tag with the version (will need to make a few minor tweaks to the code to handle scm versioning).

benkiel commented 3 years ago

@josh-hadley done!