unified-font-object / ufoNormalizer

A tool that will normalize the XML and other data inside of a UFO.
Other
51 stars 19 forks source link

Implement GitHub Actions for tests, releases #76

Closed josh-hadley closed 3 years ago

josh-hadley commented 3 years ago
coveralls commented 3 years ago

Coverage Status

Coverage decreased (-0.4%) to 87.532% when pulling dde3d9186939f1aef6a0b75df3807a9e6ea1514d on jh-actions into baa9560e886537d50f0583be010001a3d80d6d70 on master.

benkiel commented 3 years ago

@josh-hadley This is fantastic. Thank you!

josh-hadley commented 3 years ago

@josh-hadley This is fantastic. Thank you!

Sure thing Ben. You should be able to trigger a release/build/PyPI publish by pushing a tag to master with the desired version. I recommend testing with a pre-release tag first like 0.4.3a0 or some such, just in case something breaks.

Oh also, note: the Release action always sets the 'pre-release' tag on the GitHub release, even for a "final" release tag. This is kind of a safety valve. So after running it, if all looks good, go to the GitHub Release and un-tick the "This is a pre-release" checkbox on "final" releases.

I'll keep my eyes out for any issues with this and try to get on top of them as needed.

benkiel commented 3 years ago

Ah, I lived dangerously (well, I didn't see this) and pushed a non pre-release tag. It all worked, thank you so much for this.

josh-hadley commented 3 years ago

oh -- ha! awesome 😀

benkiel commented 3 years ago

To note, I made the release through GitHub, not via a tagged push.

josh-hadley commented 3 years ago

Ah -- OK that's what I figured -- the Action fails to create the release (because it's already created) but the rest of the workflow runs, so I think I'm gonna call it a day on this for now. Maybe revisit down the road, there are some other little tweaks that would be good (like only uploading coverage to Coveralls once...).

benkiel commented 3 years ago

@josh-hadley Yes, sorry, was being lazy and just did it through the web interface. Good to know it all works, thank you again.