unified-font-object / ufoNormalizer

A tool that will normalize the XML and other data inside of a UFO.
Other
51 stars 19 forks source link

Make coveralls run parallel #77

Open benkiel opened 3 years ago

benkiel commented 3 years ago

Well, that quick attempt isn't working, will come back to later.

miguelsousa commented 3 years ago

We've been using Codecov.io for a while and it has worked well for afdko and psautohint. Consider dropping Coveralls in favor of that.

miguelsousa commented 3 years ago

Also, making coverage run in parallel might be as simple as adding a line with parallel = True to the repo's .coveragerc file.

josh-hadley commented 3 years ago

~This might be of use: https://github.com/marketplace/actions/coveralls-github-action~

Edit: Oh, duh that's what you have, nevermind 🤭

It looks like the Action expects the coverage file(s) to be ./coverage/lcov.info but I believe the test command coverage run setup.py test is going to put the results into .coverage. You could try changing the Action's path-to-lcov param to .coverage instead.

If that doesn't work: looks like someone has created a coveralls action specifically for Python's coverage: https://github.com/marketplace/actions/coveralls-python

josh-hadley commented 3 years ago

Looks like that expects an actual LCOV file. Maybe let's look at that Python-specific coveralls action, or switch to codecov.io as Miguel suggested?

benkiel commented 3 years ago

Yup, will switch to codecov.io that makes sense.